Add deterministic range over map helper #1340
Merged
+114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jan 8, 2024
cretz
reviewed
Jan 9, 2024
Quinn-With-Two-Ns
force-pushed
the
issue-359
branch
from
a9789d1 to
1c516ac
Compare
cretz
approved these changes
Jan 9, 2024
cretz
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deterministic range over map helpers for ordered and unordered maps.
Ideally this would be implemented with range over func, but it is only experimental in golang 1.22 so we would have to wait over a year to use it assuming it is stabilized in 1.23.
Closes #359