Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evict workflow from cache on RespondTaskCompleted failure #1358

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Evict workflow from cache on RespondTaskCompleted failure

closes #1357

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review January 16, 2024 17:18
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 16, 2024 17:18
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, crazy that was broken this whole time. Did this work with something like sending a complete where an activity is missing any specified timeouts? That's a common case where completing the task "fails" but I can't remember if that counts as the call failing or succeeds but with an error inside. Might be worth adding an integ test for that too since it's easy.

@Quinn-With-Two-Ns
Copy link
Contributor Author

Did this work with something like sending a complete where an activity is missing any specified timeouts?

That wouldn't cause any issue before because when receiving the new workflow task the SDK would detect the cache as stale and evict at that point. This only causes issues in very specific scenarios that manage to bypass the SDKs cache checks and those situations are very hard to trigger with an integration test.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 41d2288 into temporalio:master Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK should evict workflow execution from cache on failure to respond to a workflow task
2 participants