get-free-port: prevent duplicate ports on Linux #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
May 17, 2024
testsuite/freeport.go
Outdated
| // Modified from Temporalite which itself modified from | ||
| // https://github.com/phayes/freeport/blob/95f893ade6f232a5f1511d61735d89b1ae2df543/freeport.go | ||
| // Copied and adapted from | ||
| // https://github.com/mjameswh/temporalio-cli/blob/6b5a708e51da89dbdfd4fda7b7219ae12bcd8ffb/temporalcli/devserver/freeport.go |
There was a problem hiding this comment.
Can point to PR instead of personal repo
testsuite/freeport.go
Outdated
| if err != nil { | ||
| return "", 0, err | ||
| return "", 0, fmt.Errorf("failed to assign a free port: %v", err) |
There was a problem hiding this comment.
Suggested change
| return "", 0, fmt.Errorf("failed to assign a free port: %v", err) | |
| return "", 0, fmt.Errorf("failed to assign a free port: %w", err) |
nit
Quinn-With-Two-Ns
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
TIME_WAITstate. This avoids various race conditions that could happen due to the port being reallocated between the moment the port is obtained and the moment the server actually binds to that port. See get-free-port: prevent duplicate ports on Linux cli#564 for details.