Add integration test for reset with update events #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| Reason: "integration test", | ||
| WorkflowTaskFinishEventId: 4, | ||
| ResetReapplyType: enumspb.RESET_REAPPLY_TYPE_ALL_ELIGIBLE, |
There was a problem hiding this comment.
@dandavison The api docs say the default value for ResetReapplyType is RESET_REAPPLY_TYPE_ALL_ELIGIBLE, but that does not appear to be the case as if I don't specify it manually the test fails. Is this a bug?
There was a problem hiding this comment.
I think that's because you also have specified exclude. You can't specify both. One or the other.
There was a problem hiding this comment.
I throw an error on that in Core actually
Quinn-With-Two-Ns
force-pushed
the
update-reset-integration-test
branch
from
12fc23f to
03995ea
Compare
Quinn-With-Two-Ns
force-pushed
the
update-reset-integration-test
branch
from
03995ea to
e531dd8
Compare
Sushisource
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test for reset with update events.