Add support for query parameter when listing schedules #1556
Conversation
|
|
Guard for eventual consistency
There was a problem hiding this comment.
LGTM (though Eventually has a bit of a poor impl on the testify side, but probably fine here). Will leave open a bit to confirm @Quinn-With-Two-Ns has nothing to add.
Also, can you confirm you have privileges to "merge" this? If not, we can merge for you.
| @@ -199,6 +199,7 @@ func (sc *scheduleClient) List(ctx context.Context, options ScheduleListOptions) | |||
| Namespace: sc.workflowClient.namespace, | |||
| MaximumPageSize: int32(options.PageSize), | |||
| NextPageToken: nextToken, | |||
| Query: options.Query, | |||
There was a problem hiding this comment.
Is there any issue on the server side when passing both a Query string and a NextPageToken? I don't think we do this anywhere else in the Go SDK and want to make sure the server does the correct thing.
There was a problem hiding this comment.
ListWorkflowExecutions? The SDK doesn't call it but it exposes it to be used that way. IOW the token does not encapsulate the query, you still need the query.
There was a problem hiding this comment.
yeah the SDK doesn't wrap ListWorkflowExecutions so I wasn't sure on the contract.
What was changed
Add support for query parameter when listing schedules
Checklist
Closes Support "query" when listing schedules #1539
How was this tested:
Added integration test cases