-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing schedule search attributes when when updating a schedule #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Jul 24, 2024
cretz
reviewed
Jul 24, 2024
justinp-tt
changed the title
Add support for defining search attributes when updating schedules
Add support for managing schedule search attributes when when updating a schedule
Jul 24, 2024
- Added types search attribute field - more integration tests
justinp-tt
force-pushed
the
justinp-tt/update-schedule-query-support
branch
from
July 24, 2024 20:55
45de775
to
b0994bd
Compare
cretz
reviewed
Jul 24, 2024
- Add upsert test
dnr
reviewed
Jul 25, 2024
cretz
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one thing about tests, but not considering it blocking
- Eventually --> EventuallyWithT
- Add more tests - Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add support for managing schedule search attributes when when updating a schedule
Checklist
Closes Support Search Attributes in Schedules via Query Update #1561
How was this tested:
Added new integration test