Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for managing schedule search attributes when when updating a schedule #1562

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

justinp-tt
Copy link
Contributor

@justinp-tt justinp-tt commented Jul 23, 2024

What was changed

Add support for managing schedule search attributes when when updating a schedule

Checklist

  1. Closes Support Search Attributes in Schedules via Query Update #1561

  2. How was this tested:
    Added new integration test

@justinp-tt justinp-tt marked this pull request as ready for review July 23, 2024 22:24
@justinp-tt justinp-tt requested a review from a team as a code owner July 23, 2024 22:24
test/integration_test.go Outdated Show resolved Hide resolved
internal/schedule_client.go Outdated Show resolved Hide resolved
test/integration_test.go Show resolved Hide resolved
@justinp-tt justinp-tt changed the title Add support for defining search attributes when updating schedules Add support for managing schedule search attributes when when updating a schedule Jul 24, 2024
@justinp-tt justinp-tt force-pushed the justinp-tt/update-schedule-query-support branch from 45de775 to b0994bd Compare July 24, 2024 20:55
internal/schedule_client.go Outdated Show resolved Hide resolved
internal/schedule_client.go Outdated Show resolved Hide resolved
internal/schedule_client.go Show resolved Hide resolved
test/integration_test.go Show resolved Hide resolved
test/integration_test.go Outdated Show resolved Hide resolved
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one thing about tests, but not considering it blocking

test/integration_test.go Show resolved Hide resolved
@justinp-tt justinp-tt enabled auto-merge (squash) July 25, 2024 18:28
@justinp-tt justinp-tt merged commit bcc623d into master Jul 25, 2024
14 checks passed
@justinp-tt justinp-tt deleted the justinp-tt/update-schedule-query-support branch July 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Search Attributes in Schedules via Query Update
4 participants