Protect against legacy queries when state is destroyed #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Nice. I can see how a 0-cache integration test didn't catch this because that disables sticky. I wonder if we should have some kind of test that still has cache/sticky enabled but clears cache after each task completion to exercise all the sticky history refetch behavior.
|
Clearing cache actually wouldn't catch this, it requires a destroyed cached execution. Maybe the long term solution is to refactor the SDK to remove this concept of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect against legacy queries when workflow execution is destroyed. Previously the SDK would panic since legacy queries against a cached execution have no history.
closes #1567