Do not warn on unfinished handlers if workflow failed #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Aug 6, 2024
Sushisource
approved these changes
Aug 6, 2024
Comment on lines
+700
to
704
| // Verify that the workflow did not fail. If it did we will not warn about unhandled updates. | ||
| var canceledErr *CanceledError | ||
| var contErr *ContinueAsNewError | ||
| if len(updatesToWarn) > 0 && (rp.error == nil || errors.As(rp.error, &canceledErr) || errors.As(rp.error, &contErr)) { | ||
| env.GetLogger().Warn(unhandledUpdateWarningMessage, "Updates", updatesToWarn) |
There was a problem hiding this comment.
You know we never discussed this but perhaps it makes sense to log them at debug level for workflow failing case?
Not a big deal either way.
There was a problem hiding this comment.
Hmm I think I would punt on this for now. I suspect we will be doing more work on warning on dangling "things" (like activities) in workflow and can resist then
Quinn-With-Two-Ns
force-pushed
the
issue-1580
branch
from
174dd0d to
c206e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not warn on unfinished handlers if workflow failed
closes #1580