Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docstring grammar updates in activity.go #1608

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

yuandrew
Copy link
Contributor

What was changed

Minor grammar improvements for docstrings in activity.go

Why?

Saw a note somewhere that our docstrings could use some grammar corrections. Thought I'd take a small stab at activity.go while I perused the file. Not a commitment to fix all of our docstring's grammar :), but this should be a small improvement.

Checklist

  1. Closes

  2. How was this tested:

Only docstrings updated, no code changes

  1. Any docs updates needed?

@yuandrew yuandrew requested a review from a team as a code owner August 21, 2024 23:06
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

@yuandrew yuandrew force-pushed the improve_docstring_grammar branch from 2ce7fbe to 76ce378 Compare August 21, 2024 23:49
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Looks like CI may have a flaky test. I'd kick it again, but it'll automatically run again when you update master into this branch (can just click "update branch" in the PR).

@yuandrew yuandrew merged commit 9bcc1a9 into temporalio:master Aug 22, 2024
12 checks passed
@yuandrew yuandrew deleted the improve_docstring_grammar branch August 22, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants