Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable CLI for tests #1637

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Use stable CLI for tests #1637

merged 2 commits into from
Sep 17, 2024

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Sep 16, 2024 •
edited
Loading

Addressing a TODO I put in the code when working on Nexus while it wasn't available in a stable server / CLI release.

Also:

@bergundy bergundy requested a review from a team as a code owner September 16, 2024 23:14
@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Sep 16, 2024 •
edited
Loading

What about all the DISABLE_SERVER_1_25_TESTS code? That was also added as part of the nexus PR and should be cleaned up no?

50e993e

@bergundy
Copy link
Member Author

What about all the DISABLE_SERVER_1_25_TESTS code? That was also added as part of the nexus PR and should be cleaned up no?

50e993e

They're mostly related to worker versioning apart from temporalio/temporal#6319. I'll defer to the versioning crew for enabling those.

@ShahabT, @carlydf, @antlai-temporal

@Quinn-With-Two-Ns
Copy link
Contributor

And DISABLE_NEXUS_TESTS there is also a TODO under your name

sdk-go/.github/workflows/ci.yml

Line 93 in 592ae12

DISABLE_NEXUS_TESTS: "1"
hehe

@bergundy
Copy link
Member Author

And DISABLE_NEXUS_TESTS there is also a TODO under your name

sdk-go/.github/workflows/ci.yml

Line 93 in 592ae12

DISABLE_NEXUS_TESTS: "1"

hehe

Hmm... yeah, now that 1.25 is out I can remove that if I add the required dynamic configs.

@bergundy bergundy merged commit 03e0341 into temporalio:master Sep 17, 2024
13 checks passed
@bergundy bergundy deleted the stable-cli branch September 17, 2024 14:29
@bergundy bergundy mentioned this pull request Sep 17, 2024
Merged
ReyOrtiz pushed a commit to ReyOrtiz/temporal-sdk-go that referenced this pull request Dec 5, 2024
@bergundy @reynieroz
Use stable CLI for tests (temporalio#1637)
953eb33 
Addressing a TODO I put in the code when working on Nexus while it wasn't available in a stable server / CLI release.

Also:
- Use dashes instead of underscores in the test endpoint names since that logic changed since the server RC was cut.
- [Enable 1.25.0 tests with docker-compose](temporalio@719c86a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergundy @Quinn-With-Two-Ns @cretz