Annotate versioning behavior per Workflow type #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Nov 13, 2024
internal/internal_worker.go
Outdated
Comment on lines
587
to
589
| if options.VersioningBehavior != VersioningBehaviorUnspecified { | ||
| r.workflowVersioningBehaviorMap[registerName] = options.VersioningBehavior | ||
| } |
There was a problem hiding this comment.
Suggested change
| if options.VersioningBehavior != VersioningBehaviorUnspecified { | |
| r.workflowVersioningBehaviorMap[registerName] = options.VersioningBehavior | |
| } | |
| r.workflowVersioningBehaviorMap[registerName] = options.VersioningBehavior |
Could just put it in the map always and remove the , ok approach from the getter and just rely on unspecified to be equivalent to unset. Not a big deal, but I think it makes for cleaner code.
There was a problem hiding this comment.
In general I don't like adding unnecessary entries to maps, but here there is no performance/space issue and it is cleaner...
Done
yuandrew
reviewed
Nov 13, 2024
antlai-temporal
merged commit edb4b32
into
temporalio:versioning-3
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Provides an alternative mechanism to provide a default versioning behavior per workflow type using workflow registration options.
Why?
The programmatic API to set Versioning Behavior is brittle because it needs to be called during the first workflow task.
Checklist
Enable type-scoped Versioning Behavior for workflows #1698
An integration test using gRPC interceptors