Introduce separate slot supplier for session activities #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 2, 2024
Quinn-With-Two-Ns
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
There's now a separate slot supplier for session activities. Turns out this was also broken before in a different way, since previous to the slot suppliers change, session activity workers would have their own independent max concurrent, equal to the normal activity setting. Hence users using sessions could easily exceed the max number they thought they set.
Why?
Without it, pollers for the session TQ can starve the normal activity TQ of slots
Checklist
Closes Session worker delays with single activity limit after Tuner introduction #1732
How was this tested:
Added integ test
Any docs updates needed?
Need to add some Go specific changes to docs on slot suppliers