-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mock: in order mock calls using new testify mock.InOrder() method #1743
Conversation
|
1 similar comment
|
Looks like your branch isn't up to date and there are merge conflicts, please rebase and then we can run CI, thanks for the contribution |
Ok, branch rebased and merge conflicts resolved. Thanks! |
is there anything I need to do to fix the pipeline failures? |
You will want to run |
Thanks and sorry I missed that. I ran |
Just waiting on the CLA to be signed, then we can merge |
Ok, I've signed a couple of times. It seems it doesn't refresh automatically. Now says "You have agreed to the CLA for multiple repositories or organizations" |
What was changed
Upgrading testify to
v1.10.0
.Adding an InOrderMockCalls(calls ...*MockCallWrapper) helper method to setup mock calls in order. It implements a similar helper that was recently added and released in to https://github.com/stretchr/testify.
I had opened a similar PR in the past: #1623 but was canceled because the helper methods implemented in temporal are similar to the ones offered by "testify", and it was already added to "testify".
Why?
A more intuitive and cleaner way to define mock calls in order. For example:
Checklist
Closes
How was this tested: