Fix GetWorkflow to provide latest run id if none was provided to it #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e was not provided
mfateev
reviewed
Nov 20, 2020
| // and extract run id from there. This is definitely less efficient than it could be if there was a more specific | ||
| // rpc method for this, or if there were more granular history filters - in which case it could be extracted from | ||
| // the `iterFn` inside of `workflowRunImpl` | ||
| if runID == "" { |
There was a problem hiding this comment.
I would move this code into workflowRunImpl.GetRunID to save the roundtrip for cases when runID is not being accessed.
There was a problem hiding this comment.
Makes sense, initially I had tried doing this with the history iterator, but found the events wouldn't contain what I needed. I'll plumb in a way to access the client from inside GetRunID -- or perhaps make runID be lazily loaded.
There was a problem hiding this comment.
Made this lazy-load.
mfateev
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #272
I'm not totally sure this is the way we want to go about this, though, so would very much appreciate feedback on the approach. I left some detail in a comment.