-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use go 1.16 #369
Merged
Merged
Use go 1.16 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
requested review from
mfateev,
Sushisource and
vitarb
as code owners
February 24, 2021 05:54
Sushisource
approved these changes
Feb 24, 2021
sergeybykov
approved these changes
Feb 24, 2021
For what it's worth, I run into a handful of build errors when using this branch with go 1.16. Would these errors go away once the package is published to go.temporal.io?
|
@andrewcohen this PR aims to update the master branch of go SDK, there will be release afterwards. before the release, we will upgrade our internal package for verification. |
lminaudier
added a commit
to lminaudier/temporal-go-sdk
that referenced
this pull request
Mar 31, 2021
This reverts commit 50a785d.
lminaudier
added a commit
to lminaudier/temporal-go-sdk
that referenced
this pull request
Apr 1, 2021
This reverts commit 50a785d.
lminaudier
added a commit
to lminaudier/temporal-go-sdk
that referenced
this pull request
Apr 1, 2021
This reverts commit 50a785d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.