Health check retry #453
Merged
Health check retry #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
reviewed
May 27, 2021
internal/client.go
Outdated
| @@ -423,6 +425,10 @@ type ( | |||
| // Default: 5s. | |||
| HealthCheckTimeout time.Duration | |||
|
|
|||
| // HealthCheckRetryFor defines maximum amount of time that health check should be retried for. | |||
| // Defaults to 10s, once this timeout is reached error will be propagated to the client. | |||
| HealthCheckRetryFor time.Duration | |||
There was a problem hiding this comment.
[Nit] I think we need better name here. OR, HealthCheckTimeout should represent the overall time including all attempts, and we have the new field specify the PerAttempt timeout (or have that hard-coded). I can see how this might cause some weirdness with breaking changes though...
There was a problem hiding this comment.
We can slightly turn it and add HealthCheckAttemptTimeout, which would allow us to use HealthCheckTimeout as an aggregate one, what do you think?
mastermanu
approved these changes
May 27, 2021
mfateev
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #438 by adding configurable healthcheck timeout for the client.
Default value is set to 10 seconds, which means that now client creation would block sending health check requests in case if server is not available.