Don't use data converter if search attribute value is of Payload type #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Sep 19, 2022
alexshtin
force-pushed
the
feature/sa-payload
branch
from
5eb497a to
0596f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Don't use data converter if search attribute value is of
Payloadtype.Why?
WorkflowInfocontains search attributes with values encoded inPayload. To start child workflow with same search attributes, workflow code needs to decode them and then set it back. To do this, it must know all name and types which is not always possible. This is small workaround which allows to copy search attributes from current workflow to child.