Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call ResetSticky on force eviction #915

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

yiminc
Copy link
Member

@yiminc yiminc commented Sep 20, 2022

There are 2 benefits of calling ResetSticky:

  1. so that next workflow task will contain full history, and worker won’t need to poll for the missing history separately.
  2. there will be no 5s delay if no sticky worker on that sticky queue.

For #1, to gain that benefit of one less GetHistory call, we pay one extra call to ResetSticky which is a CAS operation and is much expensive than GetHistory.
For #2, matching service will return NoStickyWorkerAvailable and there will be no 5s delay if sticky worker is gone.

@yiminc yiminc requested a review from a team as a code owner September 20, 2022 23:37
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit to not understanding the manual reset sticky, so I trust your judgement here.

@yiminc yiminc merged commit 754b253 into temporalio:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants