Add ci trigger for sdk-features #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
sdk-features-ci
branch
from
b3cb804 to
7b42c5a
Compare
|
This is working as expected, but breakage from #959 must be addressed in SDK-features |
Sushisource
force-pushed
the
sdk-features-ci
branch
4 times, most recently
from
d6ff92e to
66a8e45
Compare
Sushisource
force-pushed
the
sdk-features-ci
branch
from
66a8e45 to
530988d
Compare
|
Oops, forgot to mark this one ready. The breaking change issue still stands, but we don't necessarily need to address it before merge (I also forgot to add the branch override for the go workflow, which I'll be doing soon as part of my next PR to sdk-features, so we could wait until then too). |
bergundy
approved these changes
Nov 19, 2022
cretz
approved these changes
Nov 21, 2022
|
I will merge this, and we can figure out the failure-fix-in-branch deal later, since this isn't set to block PRs yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until temporalio/features#162 is merged