Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/tally: improve godoc with links #985

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Dec 22, 2022

Add doc links in package contrib/tally following godoc improvements in Go 1.19. See https://go.dev/doc/comment

What was changed

Improve godoc for package contrib/tally by adding doc links.
See https://go.dev/doc/comment.

Why?

Link to upstream tally package from this package documentation.

@dolmen dolmen requested a review from a team as a code owner December 22, 2022 18:58
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dolmen dolmen force-pushed the tally-add-godoc-links branch from e8c3c13 to 8183188 Compare January 5, 2023 13:45
Add doc links following godoc improvments in Go 1.19.
See https://go.dev/doc/comment
@dolmen dolmen force-pushed the tally-add-godoc-links branch from 8183188 to 2fa4a6d Compare January 9, 2023 15:54
@dolmen
Copy link
Contributor Author

dolmen commented Jan 9, 2023

Rebased.

@cretz cretz merged commit 64d80f8 into temporalio:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants