Add GetUnhandledSignalNames #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
force-pushed
the
unhandled-signal
branch
from
53be769 to
79781ec
Compare
This was referenced Jan 4, 2023
Co-authored-by: Chad Retz <chad.retz@gmail.com>
|
@longquanzheng - sorry, some of the PRs are moving fast on this repo. Can you update your branch w/ latest master (or let me know and I can)? |
no worries, I can do it. You are also welcome to do it anytiime. LMK if I need to do anything to change permission |
|
👍 Permissions were there, no extra needed, just didn't want to merge into your branch without asking. Will merge PR after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Expose the API
GetUnhandledSignalNamesWhy?
See https://temporalio.slack.com/archives/CTDTU3J4T/p1672780768847019?thread_ts=1672770053.462709&cid=CTDTU3J4T
Checklist
Closes
None. but related to [Feature Request] Standardize method for listing workflow queries/signals (and maybe other things like registered activities/workflows and other metadata) features#51
How was this tested:
There are already tests covered for this API internally in the SDK.
Maybe worth mentioning for using continueAsNew, this API will be helpful to check if all the signals are drained.