Typed search attributes #1782
Merged
Typed search attributes #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-attributes # Conflicts: # temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java # temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflowContext.java
cretz
commented
Jun 7, 2023
temporal-sdk/src/main/java/io/temporal/internal/statemachines/ActivityStateMachine.puml
Outdated
Show resolved
Hide resolved
Sushisource
approved these changes
Jun 7, 2023
temporal-sdk/src/main/java/io/temporal/common/SearchAttributes.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflowContext.java
Outdated
Show resolved
Hide resolved
bergundy
reviewed
Jun 7, 2023
temporal-sdk/src/main/java/io/temporal/internal/common/SearchAttributePayloadConverter.java
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/common/SearchAttributePayloadConverter.java
Show resolved
Hide resolved
cretz
force-pushed
the
typed-search-attributes
branch
from
5f6208b to
7e25eee
Compare
Quinn-With-Two-Ns
approved these changes
Jun 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Implementation of typed search attributes. Specifically:
SearchAttributes(with builder) andSearchAttributeKeyandSearchAttributeUpdatetoio.temporal.commonThe tests were just written to have the same coverage as existing tests, but are admittedly probably not enough and more could be written for edge cases (e.g. using old API to set multiple int attributes and trying to use them with new API which only allows one).