Test server Nexus endpoint operator apis #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdoerner
commented
Jul 31, 2024
temporal-test-server/src/main/java/io/temporal/internal/testservice/TestNexusEndpointStore.java
Outdated
Show resolved
Hide resolved
bergundy
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Overall LGTM. Will defer to @Quinn-With-Two-Ns for the approval.
...l-test-server/src/main/java/io/temporal/internal/testservice/TestNexusEndpointStoreImpl.java
Outdated
Show resolved
Hide resolved
...l-test-server/src/main/java/io/temporal/internal/testservice/TestNexusEndpointStoreImpl.java
Show resolved
Hide resolved
|
Overall LGTM, are we able to add tests as well? Ideally we can add test that both verify the API behaves as expected, and behaves like the real server. Here is what I did for update 6b39e44. |
pdoerner
commented
Aug 2, 2024
| @Rule public SDKTestWorkflowRule testWorkflowRule = SDKTestWorkflowRule.newBuilder().build(); | ||
|
|
||
| @Before | ||
| public void checkExternal() { |
There was a problem hiding this comment.
Opened #2165 to remove skip once 1.25.0 is officially released
Quinn-With-Two-Ns
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated API to
v1.36.0Added test server implementations of Nexus endpoint CRUD APIs to TestOperatorService
Why?
To support implementing Nexus operations in the test server.
Checklist
Closes
How was this tested: