Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Workflow Method after Signal if it's' signalWithStart #483

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Aug 6, 2024

What was changed

A fix has been added where the Workflow Method starts after the initial signals on signalWithStart().
To avoid a breaking change, the class \Temporal\FeatureFlags with the flag $workflowDeferredInitialization = false was added. To activate the new behavior, set this flag to true.

// Set flags
\Temporal\FeatureFlags::$workflowDeferredHandlerStart = true;

// Create Workers
$factory = WorkerFactory::create();
// ...

Note

The feature marked as experimental

Checklist

  1. Closes Signal from signal-with-start must be processed before Workflow Handler initialization #457
  2. How was this tested: added autotest
  3. Any docs updates needed?

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:42pm

@roxblnfk roxblnfk merged commit 7090b9d into master Aug 7, 2024
92 checks passed
@roxblnfk roxblnfk deleted the deferred-workflow-iterator branch August 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal from signal-with-start must be processed before Workflow Handler initialization
2 participants