Add workflow ID on not-found activity error message (#428)

Fixes #416
temporalio · Feb 20, 2024 · 1cfdaa8 · 1cfdaa8
1 parent b0a7b4e
commit 1cfdaa8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/temporalio/worker/_activity.py b/temporalio/worker/_activity.py
@@ -286,7 +286,8 @@ async def _run_activity(
             if not activity_def:
                 activity_names = ", ".join(sorted(self._activities.keys()))
                 raise temporalio.exceptions.ApplicationError(
-                    f"Activity function {start.activity_type} is not registered on this worker, available activities: {activity_names}",
+                    f"Activity function {start.activity_type} for workflow {start.workflow_execution.workflow_id} "
+                    f"is not registered on this worker, available activities: {activity_names}",
                     type="NotFoundError",
                 )
 

diff --git a/tests/worker/test_activity.py b/tests/worker/test_activity.py
@@ -544,10 +544,7 @@ async def say_hello(name: str) -> str:
                 id=str(uuid.uuid4()),
                 task_queue=worker.task_queue,
             )
-    assert str(assert_activity_application_error(err.value)) == (
-        "NotFoundError: Activity function wrong_activity is not registered on this worker, "
-        "available activities: say_hello"
-    )
+    assert "is not registered" in str(assert_activity_application_error(err.value))
 
 
 async def test_max_concurrent_activities(client: Client, worker: ExternalWorker):