Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Logic bug for create_schedule + backfill w/out trigger immediately #678

Closed
cretz opened this issue Oct 29, 2024 · 0 comments · Fixed by #693
Closed

[Bug] Logic bug for create_schedule + backfill w/out trigger immediately #678

cretz opened this issue Oct 29, 2024 · 0 comments · Fixed by #693
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Oct 29, 2024

Describe the bug

Looking at code while developing Ruby SDK, it seems at

if input.trigger_immediately or input.backfill:
initial_patch = temporalio.api.schedule.v1.SchedulePatch(
trigger_immediately=temporalio.api.schedule.v1.TriggerImmediatelyRequest(
overlap_policy=temporalio.api.enums.v1.ScheduleOverlapPolicy.ValueType(
input.schedule.policy.overlap
),
),
backfill_request=[b._to_proto() for b in input.backfill],
)
we are always setting trigger immediately even it user set it to false but provided backfills. .NET properly does not set this.

@cretz cretz added the bug Something isn't working label Oct 29, 2024
josh-berry added a commit that referenced this issue Nov 22, 2024
Don't ask for immediate trigger when a backfill is requested, and don't
ask for a backfill when an immediate trigger is requested.

Closes #678.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant