fix: WorkflowHandle.signal() can take a string, default args to [] (#297

)
temporalio · Oct 13, 2021 · f345ef9 · f345ef9
1 parent da59776
commit f345ef9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/client/src/workflow-client.ts b/packages/client/src/workflow-client.ts
@@ -71,15 +71,15 @@ export interface WorkflowHandle<T extends Workflow> extends BaseWorkflowHandle<T
    * await handle.query<number, []>('getValue');
    * ```
    */
-  query<Ret, Args extends any[]>(def: QueryDefinition<Ret, Args> | string, ...args: Args): Promise<Ret>;
+  query<Ret, Args extends any[] = []>(def: QueryDefinition<Ret, Args> | string, ...args: Args): Promise<Ret>;
 
   /**
    * Sends a signal to a running Workflow or starts a new one if not already running and immediately signals it.
    * Useful when you're unsure of the Workflows' run state.
    *
    * @returns the runId of the Workflow
    */
-  signalWithStart<Args extends any[]>(
+  signalWithStart<Args extends any[] = []>(
     def: SignalDefinition<Args> | string,
     signalArgs: Args,
     workflowArgs: Parameters<T>

diff --git a/packages/common/src/workflow-handle.ts b/packages/common/src/workflow-handle.ts
@@ -31,7 +31,7 @@ export interface BaseWorkflowHandle<T extends Workflow> {
    * await handle.signal(incrementSignal, 3);
    * ```
    */
-  signal<Args extends any[]>(def: SignalDefinition<Args>, ...args: Args): Promise<void>;
+  signal<Args extends any[] = []>(def: SignalDefinition<Args> | string, ...args: Args): Promise<void>;
 
   /**
    * The workflowId of the current Workflow

diff --git a/packages/workflow/src/workflow-handle.ts b/packages/workflow/src/workflow-handle.ts
@@ -14,7 +14,7 @@ export interface ExternalWorkflowHandle {
    * await handle.signal(incrementSignal, 3);
    * ```
    */
-  signal<Args extends any[]>(def: SignalDefinition<Args> | string, ...args: Args): Promise<void>;
+  signal<Args extends any[] = []>(def: SignalDefinition<Args> | string, ...args: Args): Promise<void>;
 
   /**
    * Cancel the external Workflow execution.