Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose classes TextEncoder and TextDecoder in Workflow sandbox #1550

Closed
mjameswh opened this issue Oct 22, 2024 · 1 comment · Fixed by #1562
Closed

[Feature Request] Expose classes TextEncoder and TextDecoder in Workflow sandbox #1550

mjameswh opened this issue Oct 22, 2024 · 1 comment · Fixed by #1562
Labels
enhancement New feature or request

Comments

@mjameswh
Copy link
Contributor

Proposition

Expose WHATWG's TextEncode and TextDecode classes in workflow context.

Why

  • This API includes no feature that could break workflow determinism (e.g. no file IO).
  • Users have mentioned the need to use this API from a workflow context.
  • At the moment, this requires either delegating this usage to a local activity (or a regular activity) or having users load an appropriate polyfill.
@lukeramsden
Copy link
Contributor

This was useful for my usecase (using typeid-js to generate IDs in workflows, the Math.random stub in the isolate is sufficient as these don't need to be cryptographically secure) so I've opened a PR based on a patch I have locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants