Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esm support #303

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Esm support #303

merged 2 commits into from
Oct 15, 2021

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Oct 15, 2021 •
edited
Loading

Closes #279

Had to get rid of the exported child workflow assertion in createChildWorkflowHandle.
Added integration test with new fetch-esm sample.

@bergundy bergundy self-assigned this Oct 15, 2021
@bergundy bergundy requested a review from swyxio October 15, 2021 04:55
swyxio
swyxio approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@swyxio swyxio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! do we need to document using mjs extension?

@bergundy
Copy link
Member Author

No need for mjs it's just for this one script.
See the relevant sample here: temporalio/samples-typescript#31

@bergundy bergundy merged commit eddc01d into main Oct 15, 2021
@bergundy bergundy deleted the esm-support branch October 15, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swyxio swyxio swyxio approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees

@bergundy bergundy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Plan for supporting npm modules that require ESM, eg node-fetch
2 participants
@bergundy @swyxio