remove service account FF toggle (#386)

temporalio · Sep 3, 2024 · 89fff33 · 89fff33
1 parent 5fbbd58
commit 89fff33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 18 deletions.
diff --git a/app/app.go b/app/app.go
@@ -32,11 +32,7 @@ func NewApp(params AppParams) (*cli.App, error) {
 	var commands []*cli.Command
 
 	for _, command := range params.Commands {
-		if command.Name == "service-account" {
-			if IsFeatureEnabled(ServiceAccountFeatureFlag) {
-				commands = append(commands, command)
-			}
-		} else if command.Name == "nexus" {
+		if command.Name == "nexus" {
 			if IsFeatureEnabled(NexusFeatureFlag) {
 				commands = append(commands, command)
 			}

diff --git a/app/feature.go b/app/feature.go
@@ -11,13 +11,12 @@ import (
 )
 
 var (
-	GCPSinkFeatureFlag        = "enable-gcp-sink"
-	ServiceAccountFeatureFlag = "enable-service-account"
-	NexusFeatureFlag          = "enable-nexus"
-	featureflagFileName       = "feature.json"
+	GCPSinkFeatureFlag  = "enable-gcp-sink"
+	NexusFeatureFlag    = "enable-nexus"
+	featureflagFileName = "feature.json"
 )
 
-var supportFeatureFlags = []string{GCPSinkFeatureFlag, ServiceAccountFeatureFlag, NexusFeatureFlag}
+var supportFeatureFlags = []string{GCPSinkFeatureFlag, NexusFeatureFlag}
 
 type FeatureFlag struct {
 	Name  string `json:"Name"`
@@ -134,14 +133,6 @@ func NewFeatureCommand() (CommandOut, error) {
 						return toggleFeature(GCPSinkFeatureFlag)
 					},
 				},
-				{
-					Name:    "toggle-service-account",
-					Aliases: []string{"tsa"},
-					Usage:   "switch service account on/off",
-					Action: func(c *cli.Context) error {
-						return toggleFeature(ServiceAccountFeatureFlag)
-					},
-				},
 				{
 					Name:    "toggle-nexus",
 					Aliases: []string{"tnxs"},