Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prompt to set auth method #345

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Add prompt to set auth method #345

merged 11 commits into from
Apr 18, 2024

Conversation

shakeelrao
Copy link
Contributor

@shakeelrao shakeelrao commented Apr 18, 2024 •
edited
Loading

Add a confirmation prompt to disruptive AuthMethod changes.

tminusplus
tminusplus approved these changes Apr 18, 2024
View reviewed changes
app/namespace.go Outdated Show resolved Hide resolved
app/namespace.go Outdated Show resolved Hide resolved
@shakeelrao shakeelrao enabled auto-merge (squash) April 18, 2024 21:06
@shakeelrao shakeelrao merged commit c904bbb into main Apr 18, 2024
4 checks passed
@shakeelrao shakeelrao deleted the shak/auth-prompt branch April 18, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tminusplus tminusplus tminusplus approved these changes

@mattkim mattkim Awaiting requested review from mattkim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakeelrao @tminusplus