Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add retry for grpc call #363

Merged
merged 2 commits into from
Jul 9, 2024
Merged

add retry for grpc call #363

merged 2 commits into from
Jul 9, 2024

Conversation

alice-yin
Copy link
Contributor

@alice-yin alice-yin commented Jul 9, 2024 •
edited
Loading

What was changed

parallel -j 30 ./tcld --server "saas-api.tmprl-test.cloud:443" n get -n aliceyin-mrn-bug-bash.temporal-dev ::: {1..30} >> log

I could see the cmd failed initially due to rate limit.

No error after the current change.

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@alice-yin alice-yin requested a review from a team as a code owner July 9, 2024 21:53
@alice-yin alice-yin changed the title add retry for grpc add retry for grpc call Jul 9, 2024
@alice-yin alice-yin force-pushed the aliceyin/add_retry_logic_for_client branch from 40099b2 to a7e4e2a Compare July 9, 2024 22:07
@alice-yin alice-yin enabled auto-merge (squash) July 9, 2024 22:23
@alice-yin alice-yin merged commit 3a11b52 into main Jul 9, 2024
4 checks passed
@alice-yin alice-yin deleted the aliceyin/add_retry_logic_for_client branch July 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tminusplus tminusplus tminusplus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-yin @tminusplus