Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retention flag, call to update retention #93

Merged
merged 14 commits into from
Oct 31, 2022
Merged

Add retention flag, call to update retention #93

merged 14 commits into from
Oct 31, 2022

Conversation

laniehei
Copy link
Member

Add ability to update retention on a namespace

@laniehei laniehei requested a review from a team October 26, 2022 23:47
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/flags.go Outdated Show resolved Hide resolved
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/flags.go Outdated Show resolved Hide resolved
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/flags.go Outdated Show resolved Hide resolved
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/namespace.go Outdated Show resolved Hide resolved
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/namespace.go Outdated Show resolved Hide resolved
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/namespace.go Outdated Show resolved Hide resolved
mastermanu
mastermanu reviewed Oct 31, 2022
View reviewed changes
app/namespace.go Outdated Show resolved Hide resolved
mastermanu
mastermanu previously requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@mastermanu mastermanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments

anekkanti
anekkanti approved these changes Oct 31, 2022
View reviewed changes
app/namespace.go Outdated Show resolved Hide resolved
@laniehei laniehei merged commit 252dafe into main Oct 31, 2022
@laniehei laniehei deleted the namespace/update-retention branch October 31, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anekkanti anekkanti anekkanti approved these changes

@mastermanu mastermanu Awaiting requested review from mastermanu

@feihuang feihuang Awaiting requested review from feihuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laniehei @feihuang @mastermanu @anekkanti