Detecting stale cache when RecordChildExecutionCompleted (#2354)

temporalio · Jan 7, 2022 · fde1e4e · fde1e4e
1 parent b13fccf
commit fde1e4e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -2262,6 +2262,9 @@ func (e *historyEngineImpl) RecordChildExecutionCompleted(
 
 			// Check mutable state to make sure child execution is in pending child executions
 			ci, isRunning := mutableState.GetChildExecutionInfo(initiatedID)
+			if !isRunning && initiatedID >= mutableState.GetNextEventID() {
+				return nil, consts.ErrStaleState
+			}
 			if !isRunning || ci.StartedId == common.EmptyEventID {
 				return nil, serviceerror.NewNotFound("Pending child execution not found.")
 			}