Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to resource_exhausted error and emit metrics with tag of type #2412

Closed
yiminc opened this issue Jan 25, 2022 · 1 comment
Closed

Add type to resource_exhausted error and emit metrics with tag of type #2412

yiminc opened this issue Jan 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@yiminc
Copy link
Member

yiminc commented Jan 25, 2022

Currently, there are 2 reasons that could trigger resource_exhausted: exceed RPS limit, or exceed concurrent poller limit.
We would like to include resource_type to resource_exhausted error and emit metrics with tag of type when resource_exhausted error is returned.
@yiminc yiminc added the enhancement New feature or request label Jan 25, 2022
@yiminc yiminc changed the title Add type to resource_exhausted error and emit metrics with tag of limit type Add type to resource_exhausted error and emit metrics with tag of type Jan 25, 2022
@yiminc
Copy link
Member Author

yiminc commented Jan 28, 2022

#2423

@yiminc yiminc closed this as completed Jan 28, 2022
@paulnpdev paulnpdev mentioned this issue Jan 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yiminc