Add resource_exhausted_cause metrics tag #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
force-pushed
the
resource_exhausted
branch
from
ce84979 to
b1e6a7d
Compare
yiminc
force-pushed
the
resource_exhausted
branch
from
b1e6a7d to
8cb82bd
Compare
yycptt
reviewed
Jan 27, 2022
alexshtin
approved these changes
Jan 27, 2022
dnr
reviewed
Feb 3, 2022
| @@ -34,7 +35,7 @@ import ( | |||
|
|
|||
| var ( | |||
| // ErrPersistenceLimitExceeded is the error indicating QPS limit reached. | |||
| ErrPersistenceLimitExceeded = serviceerror.NewResourceExhausted("Persistence Max QPS Reached.") | |||
| ErrPersistenceLimitExceeded = serviceerror.NewResourceExhausted(enumspb.RESOURCE_EXHAUSTED_CAUSE_SYSTEM_OVERLOADED, "Persistence Max QPS Reached.") | |||
There was a problem hiding this comment.
should this be RESOURCE_EXHAUSTED_CAUSE_RPS_LIMIT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add resource_exhausted_cause metrics tag for ResourceExhaustedError metrics.
Why?
easer for oncall to handle error based on different resource type.
How did you test it?
manual verify metrics
Potential risks
no
Is hotfix candidate?
no