Update cron to v3.0 + CronSchedule Timezone support #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elb3k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Upgraded
robfig/cronfrom v1.2.0 to v3.0.0Why?
New
robfig/cronhas a support for timezone, which is requested by thisHow did you test it?
Using
develop/buildkitescripts for standard predefined testsAnd added cron tests with
CRON_TZspecified, with and without daylight saving.Potential risks
Not to my knowledge,
cronlibrary is used only in one place, andcronis backwards compatible.Is hotfix candidate?
Yes, since PR will add only minor feature