Add basic metrics unit tests #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardagan
force-pushed
the
MetricsUnitTests
branch
from
cfe2351 to
d88a2ff
Compare
yiminc
approved these changes
Dec 11, 2021
| UnitTestService: { | ||
| TestScope1: {operation: "test_scope_1_operation"}, | ||
| TestScope2: {operation: "test_scope_2_operation"}, | ||
| }, |
There was a problem hiding this comment.
do we have to add those here for testing? Is there a way to put them in test package?
There was a problem hiding this comment.
We currently initialize clients using this global variable. I'll look to separate it in other PRs.
Ardagan
force-pushed
the
MetricsUnitTests
branch
from
76f11ca to
665a83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added unit tests for metrics
Why?
Test coverage
How did you test it?
these are unit tests.
Potential risks
N/A
Is hotfix candidate?
N/A