Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --target for docker builds #2273

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Use --target for docker builds #2273

merged 1 commit into from
Dec 21, 2021

Conversation

dnr
Copy link
Member

@dnr dnr commented Dec 8, 2021 •
edited by alexshtin
Loading

What changed?
Use docker's built-in --target instead of a TARGET build arg.

Why?
Simpler, use built-in feature.

How did you test it?
Manual test.

Potential risks
If anyone else has scripts that use the build arg, they'd have to be changed.

Is hotfix candidate?
No.

@dnr dnr requested a review from a team December 8, 2021 06:58
@dnr dnr merged commit bdbfb60 into temporalio:master Dec 21, 2021
@dnr dnr deleted the docker-target branch December 21, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnr @alexshtin