Make matching service executeWithRetry function stateless #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
commented
Dec 15, 2021
Comment on lines
+45
to
+46
| dbTaskInitialRangeID = 1 | ||
| dbTaskStickyTaskQueueTTL = 24 * time.Hour |
There was a problem hiding this comment.
these 2 definitions are copy pasted from existing impl https://github.com/temporalio/temporal/blob/20bf977/service/matching/db.go#L43
so later db.go, taskReader.go, taskWriter.go, ackManager.go can simply be deleted
There was a problem hiding this comment.
once integration with new db task * are done
alexshtin
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Cleanup logic for later integration
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
No