Matching sync match task should not have completion function #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Existing logic will provide both resp channel & completion function when doing sync matching: https://github.com/temporalio/temporal/blob/v1.14.0/service/matching/taskQueueManager.go#L529
https://github.com/temporalio/temporal/blob/v1.14.0/service/matching/task.go#L83
However only resp channel will be used: https://github.com/temporalio/temporal/blob/v1.14.0/service/matching/task.go#L158
How did you test it?
Existing tests & CICD
Potential risks
N/A
Is hotfix candidate?
No