Revert persistence rate limit error type #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Dec 18, 2021
yiminc
changed the title
Ardagan
pushed a commit
to Ardagan/temporal
that referenced
this pull request
Dec 20, 2021
* Correctly handle persistence rate limit error * revert error type change
Ardagan
pushed a commit
to Ardagan/temporal
that referenced
this pull request
Dec 20, 2021
* Correctly handle persistence rate limit error * revert error type change
Ardagan
added a commit
that referenced
this pull request
Dec 20, 2021
Ardagan
added a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Revert persistence rate limit error type.
Why?
Persistence rate limiting error type was changed from ResourceExahusted to Unavailable but the shard context's handleError was not updated. This cause shard to unload/reload on this error which increases persistence load and amplify the problem.
Potential risks
No
Is hotfix candidate?
Yes