Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transient workflow task check in getRawHistory #2324

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Fix transient workflow task check in getRawHistory #2324

merged 1 commit into from
Dec 28, 2021

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Dec 27, 2021

What changed?

  • Fix transient workflow task check in getRawHistory

Why?

  • Existing check checks the wrong nextPageToken, and transient workflow task won't be returned if input nextPageToken is not empty.
  • This will cause raw transient workflow task not being sent to worker if workflow history is long (larger than one page, which will cause worker to all GetWorkflowExecutionHistory). On the worker side, we will see the premature end of stream error.

How did you test it?

  • Added unit test. Tested locally.

Potential risks

Is hotfix candidate?
Yes

@yycptt yycptt requested review from wxing1292, yiminc and a team December 27, 2021 23:40
@yycptt yycptt merged commit e1fa8f2 into temporalio:master Dec 28, 2021
@yycptt yycptt deleted the fix-getRawHistory branch December 28, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@wxing1292 wxing1292 Awaiting requested review from wxing1292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc