Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote sync match for standby namespaces #2327

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Dec 28, 2021

What changed?

  • do not persist forwarded tasks for standby namespaces

Why?

  • Forwarded tasks should never be persisted
  • Ideally child partition should not send remote sync request if namespace is passive, but child partition and parent partition may live in two different hosts and have different view of whether namespace is active or not (e.g. child think it's active while parent refreshes namespace cache first and found it's actually passive), so the check on the receiver side is still needed.
  • forwarded tasks have no ttl and will live in db forever if namespace never does failover, causing large partition issue.
  • more details here: Fix remote sync match for standby domains and task creation time cadence-workflow/cadence#4654

How did you test it?
Added unit test

Potential risks

Is hotfix candidate?
Yes

@yycptt yycptt requested review from wxing1292, yiminc and a team December 28, 2021 20:51
@yycptt yycptt merged commit 94ef184 into temporalio:master Dec 28, 2021
@yycptt yycptt deleted the fix-standby-remote-sync-match branch December 28, 2021 22:17
@yiminc yiminc mentioned this pull request Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants