Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify new tasks when workflow is potentially updated #2334

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Notify new tasks when workflow is potentially updated #2334

merged 2 commits into from
Dec 30, 2021

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Dec 30, 2021 •
edited
Loading

What changed?

  • Notify new tasks if persistence operation may succeed (applied)

Why?

How did you test it?
Added unit test

Potential risks
We may have more task loading persistence requests

Is hotfix candidate?
No

@yycptt yycptt requested review from wxing1292, yiminc and a team December 30, 2021 19:46
paulnpdev
paulnpdev approved these changes Dec 30, 2021
View reviewed changes
service/history/workflow/transaction_impl.go Outdated Show resolved Hide resolved
@yycptt yycptt merged commit 05f584c into temporalio:master Dec 30, 2021
@yycptt yycptt deleted the fix-notify-task branch December 30, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnpdev paulnpdev paulnpdev approved these changes

@yiminc yiminc yiminc approved these changes

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yycptt @wxing1292 @yiminc @paulnpdev