Fix fail workflow task and generate new workflow task #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
changed the title
yycptt
approved these changes
Dec 30, 2021
host/client_integration_test.go
Outdated
Comment on lines
665
to
666
| WorkflowRunTimeout: 10 * time.Second, | ||
| WorkflowTaskTimeout: 10 * time.Second, |
There was a problem hiding this comment.
nit: is my understanding correct that taskTimeout here must equal to runTimeout? Otherwise workflow may still succeed after the workflow task timeout? If so, probably add a comment here?
There was a problem hiding this comment.
That is correct. The timeout was intentionally set to the same so if workflow task timeout it would fail the workflow. I could add a comment to clarify.
There was a problem hiding this comment.
But the test also verify the workflow history events.
wxing1292
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Correctly handle new workflow task in case RespondWorkflowTaskCompleted failed.
Why?
In case of RespondWorkflowTaskCompleted failed, server would return error and won't be able to piggyback a new workflow task. The new workflow task needs to go through normal transfer queue -> matching -> poller route to be delivered to worker.
How did you test it?
Added new integration test
Potential risks
No
Is hotfix candidate?
No