Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow marking activity as cancelled without activity being request cancelled first #2344

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Disallow marking activity as cancelled without activity being request cancelled first #2344

merged 1 commit into from
Jan 6, 2022

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Jan 5, 2022 •
edited
Loading

What changed?

  • Disallow marking activity as cancelled without activity being request cancelled first

Why?
SDK should not try to marking activity as cancelled without activity being request cancelled first

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
No

@wxing1292 wxing1292 requested review from yiminc and a team January 5, 2022 02:12
@wxing1292 wxing1292 enabled auto-merge (squash) January 5, 2022 02:14
@wxing1292 wxing1292 disabled auto-merge January 5, 2022 02:22
@wxing1292 wxing1292 requested review from cretz and samarabbas January 5, 2022 22:47
@wxing1292 wxing1292 changed the title Allow cancel an activity if activity is not request cancelled Disallow marking activity as cancelled without activity being request cancelled first Jan 5, 2022
@cretz cretz mentioned this pull request Jan 5, 2022
Closed
@wxing1292 wxing1292 merged commit ec65088 into temporalio:master Jan 6, 2022
@wxing1292 wxing1292 deleted the allow-cancel-not-cancelled-requested branch January 6, 2022 00:48
yiminc pushed a commit that referenced this pull request Jan 7, 2022
@wxing1292 @yiminc
Disallow marking activity as cancelled without activity being request…
94b29c3 
… cancelled first (#2344)

* Disallow marking activity as cancelled without activity being request cancelled first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnpdev paulnpdev paulnpdev approved these changes

@yiminc yiminc yiminc approved these changes

@cretz cretz Awaiting requested review from cretz

@samarabbas samarabbas Awaiting requested review from samarabbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxing1292 @yiminc @paulnpdev