Rewrite TestCronWorkflow_Failed/Succeeded as SDK integration tests #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Jan 5, 2022
host/integrationbase.go
Outdated
| return events[len(events)-1] | ||
| } | ||
|
|
||
| func (s *IntegrationBase) decodePayloadsString(ps *commonpb.Payloads) (r string) { |
There was a problem hiding this comment.
about (r string)
plz define the return value within the function body and return the result
There was a problem hiding this comment.
I think these are acceptable for a three-line helper function. Also, they were just moved from another file
wxing1292
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add new integration test
TestCronWorkflowCompletionStatesusing sdk to replace two existing tests.Why?
The old tests were confusing and flaky.
How did you test it?
is a test
Potential risks
It might also be flaky: it's still dependent on real time
Is hotfix candidate?