Unload shard if loaded task ID is greater than max transfer ID #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Jan 11, 2022
yiminc
added a commit
to yiminc/temporal
that referenced
this pull request
Jan 12, 2022
…ralio#2361) * Unload shard if loaded task ID is greater than max transfer ID * Update max read level for timer task ID as well
yiminc
added a commit
that referenced
this pull request
Jan 12, 2022
* Unload shard if loaded task ID is greater than max transfer ID * Update max read level for timer task ID as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add sanity check to task processor to make sure task ID is not greater than max task ID known to this shard.
Why?
This will guard against from shard reading timer tasks generated by other shard owner while current pod lost ownership.
How did you test it?
eye_balls.
Potential risks
No
Is hotfix candidate?
No