[Docker build] add separate visibility env vars for different db instance #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Jan 11, 2022
alexshtin
approved these changes
Jan 11, 2022
|
@ yimin if you see this - yes, thats the fallback strategy so it doesnt break any experience for existing users |
yiminc
pushed a commit
that referenced
this pull request
Jan 12, 2022
|
How does this MR relate to the temporalio/auto-setup docker container? In this container there is an auto-setup script which creates the temporal and the temporal_visibility databases+schemas. Am I understanding correctly that this script should be updated to also respect the separate temporal visibility config parameters? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
add separate visibility env vars for different db instance - some deployment environments, like Render, do not allow for creating another db on the same db instance. There is no hard requirement inside of Temporal, but this assumption is baked into the docker image - so we need to offer separate env vars that people can override.
closes #1388
How did you test it?
not yet tested
Potential risks
n/a
Is hotfix candidate?
no